Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.15.0 #2109

Closed
6 of 8 tasks
oliviertassinari opened this issue Nov 9, 2015 · 7 comments
Closed
6 of 8 tasks

v0.15.0 #2109

oliviertassinari opened this issue Nov 9, 2015 · 7 comments
Labels
umbrella For grouping multiple issues to provide a holistic view

Comments

@oliviertassinari
Copy link
Member

I have a list of task in mind for the next breaking change release.

Top priority

  • Remove the menu component as it's deprecated since v0.14.0 and no longer used in the source code
  • Remove all the deprecated code
  • Change the default value of firstDayOfWeek from 0 to 1. [DatePicker] Change the behavior of firstDayOfWeek to follow ISO #2980
  • Change the default value of labelPosition for the FlatButton and RaisedButton. It should follow the labelPosition used in the Switch section.

Nice to have

@oliviertassinari oliviertassinari changed the title Next release v0.13.3 Future release v0.13.3 Nov 9, 2015
@oliviertassinari oliviertassinari changed the title Future release v0.13.3 Future release Nov 17, 2015
@alitaheri alitaheri modified the milestone: 0.14.0 Release Dec 9, 2015
@oliviertassinari oliviertassinari changed the title Future release v0.15.0 Dec 9, 2015
@oliviertassinari oliviertassinari removed this from the 0.14.0 Release milestone Dec 9, 2015
@oliviertassinari oliviertassinari added this to the 0.15.0 Release milestone Dec 23, 2015
@alitaheri alitaheri added the umbrella For grouping multiple issues to provide a holistic view label Dec 23, 2015
@mbrookes
Copy link
Member

Also, there are quite a few other issues tagged with the 0.15.0 milestone not listed above: https://github.com/callemall/material-ui/issues?q=is%3Aopen+is%3Aissue+milestone%3A%220.15.0+Release%22

Would it make sense to have a dedicated branch for 0.15.0 to allow easy release of 0.14.x releases with segregation of breaking changes targeted for 0.15.0?

@alitaheri
Copy link
Member

Change the default value of firstDayOfWeek from 0 to 1

@oliviertassinari Shouldn't by standard Monday be 0? @mbrookes I'm no expert on the standard. Is defaulting to 1 (yet starting from Saturday) against the standard?

@oliviertassinari
Copy link
Member Author

@alitaheri I'm not sure to follow your point. We have 0=Sunday and 1=Monday. Do you want to change it to 0=Monday?

@alitaheri
Copy link
Member

What I mean is, if by standard the start of the week is Monday, then it's more convenient to start COUNTING from Monday too. in other words it will be like: 6=Sunday and 0=Monday and so on. with default still being 0. instead of changing the default to 1 we rotate the days the numbers correspond to. So the standard is respected in every aspect.

@oliviertassinari
Copy link
Member Author

instead of changing the default to 1 we rotate the days the numbers correspond to.

That makes sens 👍.

@mbrookes
Copy link
Member

I thought the same, which is why I raised the question of the default in the PR, since changing the numbering in a future release could have more impact than just changing the default.

However, Date.prototype.getDay() has Sunday=0, so at least it's consistent with that.

@oliviertassinari
Copy link
Member Author

Let's move the conversation here #2980.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

3 participants