Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role="..." to Table family components when component="..." is specified #20431

Closed
ypresto opened this issue Apr 5, 2020 · 2 comments · Fixed by #20475
Closed

Add role="..." to Table family components when component="..." is specified #20431

ypresto opened this issue Apr 5, 2020 · 2 comments · Fixed by #20475
Labels
component: table This is the name of the generic UI component, not the React module! new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@ypresto
Copy link
Contributor

ypresto commented Apr 5, 2020

Summary 💡

For table accessibility, when component="..." is specified to Table family components, it'd be better to render role="..." prop.

Examples 🌈

<Table component="div" /> will be <div role="table"></div>.

Motivation 🔦

I want to make the entire row <a> tag to support some browser features like drag-and-drop link and new tab shortcut (cmd+click).

@eps1lon eps1lon added new feature New feature or request component: table This is the name of the generic UI component, not the React module! labels Apr 6, 2020
@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Apr 6, 2020
@oliviertassinari
Copy link
Member

@ypresto This sounds like a good idea. Do you want to work on the problem?

@arturbien
Copy link
Contributor

If @ypresto is busy I can take care of that ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants