Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari Service Worker Problems #13373

Closed
2 tasks done
dijonkitchen opened this issue Oct 24, 2018 · 5 comments
Closed
2 tasks done

Safari Service Worker Problems #13373

dijonkitchen opened this issue Oct 24, 2018 · 5 comments
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation priority: important This change can make a difference

Comments

@dijonkitchen
Copy link
Contributor

dijonkitchen commented Oct 24, 2018 •
edited
Loading

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Navigating around the https://material-ui.com/ site should work on Safari.

Current Behavior

Unrecoverable error after navigating and refreshing on some pages.

Workaround/Fix?

See original post for possible fix via Workbox upgrade: GoogleChrome/workbox#1730
@NekR
Copy link

NekR commented Oct 24, 2018

This is iOS 12 Safari bug.

See this: https://github.com/PWA-POLICE/pwa-bugs#problem--in-ios-12-cache-in-cache-storage-magically-disappears
And this: https://bugs.webkit.org/show_bug.cgi?id=190269

(It isn't fixed in 12.0.1)

@dijonkitchen
Copy link
Contributor Author

Thanks, but I haven't tested this on iOS Safari; this was found on macOS Safari.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation priority: important This change can make a difference labels Oct 24, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 24, 2018 •
edited
Loading

We can start by upgrading the version of workbox: https://github.com/mui-org/material-ui/blob/a74ce52105039369c8b320fdbd8aeb977c2928ee/docs/src/sw.js#L4

@msiadak Do you have some experience with the latest version of workbox?

@msiadak
Copy link
Contributor

msiadak commented Oct 24, 2018 •
edited
Loading

I don't, but I'm happy to take a look and work through the breaking changes since 3.0.0-beta.0 to try and find an upgrade path.

@oliviertassinari
Copy link
Member

@msiadak Men, this would be awesome!

@msiadak msiadak mentioned this issue Oct 26, 2018
Merged
1 task
@oliviertassinari oliviertassinari mentioned this issue Nov 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation priority: important This change can make a difference
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NekR @msiadak @oliviertassinari @dijonkitchen