-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SpeedDial] SpeedDialAction onClick not working when you click the touch screen #13006
Comments
Hi - I have looked into this particular case, and it appears that the onClick parameter is not passed along to Button component in SpeedDialAction if device is touch capable. This was introduced by the following commit: 3db734f Below is a screenshot from the commit showing that onClick is not passed to Button: At least clickProps should also contain onMouseDown: onClick. |
hi, would be great to get a fix for this. with this implementation our surface-book cannot click anymore on the button. you have to touch it. a little strange for the users ... |
Are we able to get a fix for this? |
We're still seeing this issue. I've had to set up custom behavior (showing the content on hover rather than on click) if that |
Has anyone seen newer Macbooks experiencing this issue in Chrome due to the Touchbar? |
No; I use a macbook with the touchbar at work, but the issue doesn't happen for me. I think it's due to the fact that my |
I'm seeing the same behavior is is described above. The event isn't being passed to the button on touch capable devices. Its coming up as undefined. |
one fix for me was passing the onClick via the <SpeedDialAction
key={'do-something'}
icon={<EditIcon />}
tooltipTitle={'Do something'}
tooltipOpen
// onClick={(e) => this.doAction(e)}
ButtonProps={{
onClick: (e) => this.doAction(e)
}}
/> |
Expected Behavior
Current Behavior
Steps to Reproduce
Just run the example https://material-ui.com/lab/speed-dial/ on touch screen with the mouse click.
Link:
Context
Your Environment
The text was updated successfully, but these errors were encountered: