Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField causes scrollbar flickering when focused in a form dialog #11287

Closed
1 task done
alex996 opened this issue May 9, 2018 · 4 comments
Closed
1 task done

TextField causes scrollbar flickering when focused in a form dialog #11287

alex996 opened this issue May 9, 2018 · 4 comments
Assignees
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@alex996
Copy link

alex996 commented May 9, 2018

In v1.0.0-beta.45 and onwards, when a text field in a form dialog gets focused, it causes a horizontal scroll bar to pop up and flicker for a moment. Looks like the issue is caused by #11215, as it doesn't happen in v1.0.0-beta.44.

bug

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

To not flicker a horizontal scrollbar.

Current Behavior

Flickers a horizontal scrollbar for a moment.

Steps to Reproduce (for bugs)

Reproducible within a form dialog in the current docs. I forked the example and added @babel/runtime on CodeSandbox.

  1. Click "Open Form Dialog"
  2. Unfocus the TextField by clicking outside
  3. Focus the TextField
  4. Observe the scrollbar flicker
Tech Version
Material-UI next
React 16.3.2
browser Chrome 66
@oliviertassinari
Copy link
Member

@alex996 Thanks for raising, it's a second side effect of #11215. I think that we should revert this time. cc @pandaiolo.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels May 9, 2018
@pandaiolo
Copy link
Contributor

@oliviertassinari is this is due to the label shrinking being animated, and not the width style? Would you like a PR applying the same transition to that property?

@oliviertassinari
Copy link
Member

@pandaiolo I haven't thought of animating the width. Maybe that can work. Your call.

@danjenson
Copy link

This is still an issue for me -- I have a text field in a Grid item and every time I focus or unfocus it and the label shifts, the scrollbar flickers and the page shifts jitters left and right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

4 participants