Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircularProgress spinner uses excessive cpu and gpu #11060

Closed
1 task done
fatso83 opened this issue Apr 18, 2018 · 4 comments
Closed
1 task done

CircularProgress spinner uses excessive cpu and gpu #11060

fatso83 opened this issue Apr 18, 2018 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@fatso83
Copy link

fatso83 commented Apr 18, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Spinner should not use much cpu or gpu

Current Behavior

Just keeping the spinner example demo open consumes approx 70% cpu and 65% GPU on my machine.

Steps to Reproduce (for bugs)

  1. Open Chrome
  2. Open Task Manager and observe low cpu usage
  3. Go to https://codesandbox.io/s/wwjyz58948
  4. Observe how the Task Manager shows the demo tab using much cpu and gpu

Context

Your Environment

As I am referring to the demo docs, all the versions are the latest.

Tech Version
Material-UI latest
React latest
browser Chrome
OS Ubuntu 18.04
Machine Dell XPS 9350

i7-6560U, Iris Graphics 540

@fatso83
Copy link
Author

fatso83 commented Apr 18, 2018

This might be a general problem with SVG spinners in general, mind you, but perhaps there is a common fix.

@oliviertassinari oliviertassinari added performance duplicate This issue or pull request already exists and removed performance labels Apr 18, 2018
@oliviertassinari
Copy link
Member

@fatso83 We are well aware of this problem. We have been facing this problem with the linear progress in the past. We solved it using CSS over JS: #4412. We have already been discussing this problem in #10327.

@fatso83
Copy link
Author

fatso83 commented Apr 18, 2018

I did search the issues, but it wasn't immediately obvious that #10327 related to this by reading the title. As this component is already using CSS over JS, I assume the situation can't be improved much, ref your comment:

I don't think that we could do anything to improve the current situation

Oh, well. At least the situation has been researched 👍

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 18, 2018

@fatso83 I wish we had some leverage :/. Hopefully, someone will submit a pull-request about it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants