Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useScrollLock] overflow-y: scroll support no longer working #611

Closed
oliviertassinari opened this issue Sep 14, 2024 · 2 comments
Closed
Assignees
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! regression A bug, but worse

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 14, 2024

Steps to reproduce

Steps:

  1. Go to https://master--base-ui.netlify.app/components/react-dialog/
Screen.Recording.2024-09-14.at.16.36.39.mov

Current behavior

Doesn't restore the value, it's overridden, so it introduces a layout shift.

Expected behavior

Correctly restore the previous values. For example https://github.com/mui/material-ui/blob/012c2e899b9a8977bb326746f43ef19a5f4f01a7/packages/mui-material/src/Modal/ModalManager.ts#L143 from https://mui.com/base-ui/react-modal/, it works.

Context

The support for overflow-y: scroll is needed to solve bugs like mui/material-ui#40749, until we can rely on #79.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer bug 🐛 Something doesn't work regression A bug, but worse labels Sep 14, 2024
@oliviertassinari oliviertassinari changed the title [useScrollLock] overflow-y: scroll support no longer working. [useScrollLock] overflow-y: scroll support no longer working Sep 14, 2024
@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Sep 14, 2024
@vladmoroz
Copy link
Contributor

Fixed in #604

@vladmoroz vladmoroz removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 17, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

No branches or pull requests

3 participants