Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add nextjs-hooks-with-typescript #13981

Merged
merged 10 commits into from
Dec 24, 2018
Merged

[examples] Add nextjs-hooks-with-typescript #13981

merged 10 commits into from
Dec 24, 2018

Conversation

virzak
Copy link
Contributor

@virzak virzak commented Dec 21, 2018

@virzak
Copy link
Contributor Author

virzak commented Dec 21, 2018

@oliviertassinari Any idea why deploy/netlify is failing? I don't see a single issue in the details.

@oliviertassinari oliviertassinari changed the title Added nextjs-hooks-with-typescript [examples] Add nextjs-hooks-with-typescript Dec 21, 2018
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 21, 2018
@oliviertassinari
Copy link
Member

I have rerun netlify, it's green now.

@virzak
Copy link
Contributor Author

virzak commented Dec 21, 2018

@oliviertassinari the import order was modified by VS Code setting:

{"editor.codeActionsOnSave": { "source.organizeImports": true }}

If import order is important, every project using material-ui would need to set that setting to false.

useStyles() caused a typescript error since it requires exactly one parameter.

@oliviertassinari
Copy link
Member

@virzak It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants