Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeedDial] Fix invalid prop direction supplied #12533

Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 15, 2018

During review of #12244 the names for directions changed and CI did
not run which introduced errors.

Fixes one error surfaced when opening #12531

During review mui#12244 the names for directions changed and CI did
not run which introduced errors.
@oliviertassinari oliviertassinari changed the title [SpeedDial] fix invalid prop direction supplied to SpeedDial [SpeedDial] Fix invalid prop direction supplied Aug 15, 2018
@oliviertassinari
Copy link
Member

Yeah, we weren't running the tests up until #12510.

@oliviertassinari oliviertassinari added the component: speed dial This is the name of the generic UI component, not the React module! label Aug 15, 2018
@oliviertassinari oliviertassinari merged commit 57e59af into mui:master Aug 15, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Aug 15, 2018
@mbrookes mbrookes added the package: lab Specific to @mui/lab label Sep 13, 2018
@eps1lon eps1lon deleted the fix-speed-dial-default-direction branch October 26, 2018 21:43
@oliviertassinari oliviertassinari removed the package: lab Specific to @mui/lab label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants