Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Accept boolean v2 #12522

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 14, 2018

As it turns out, people can provide a boolean too to the input, like the select, it will just be evaluated to a string.

Closes #12517

@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Aug 14, 2018
@oliviertassinari oliviertassinari merged commit 769f7d4 into mui:master Aug 14, 2018
@oliviertassinari oliviertassinari deleted the select-boolean-v2 branch August 14, 2018 18:19
@RavenHursT
Copy link

Cool.... so the output (event.target.value) of the Select or Input will still need to be translated from string -> boolean, right?

I think this is acceptable, for sure, since this is how most boolean interaction w/ DOM inputs is handled anyway.. just wanna clarify...

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 14, 2018

@RavenHursT We are unopinionated about it. Just like if you were using a raw select component, yes.

@palaniichukdmytro
Copy link
Contributor

palaniichukdmytro commented Aug 15, 2018

@oliviertassinari Should it be in next release?. So we can use <Select value={true} > or should use <Select value='true'>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants