Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar] Prepare Preact support #12519

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

jorgegorka
Copy link
Contributor

Preact returns an empty array if a component has no children therefore If (childrenProp) will always be true and else if src will never be reached.

@oliviertassinari oliviertassinari changed the title Preact support for Avatar -> Check that childrenProp if present, is not empty. [Avatar] Prepare Preact support Aug 14, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: avatar This is the name of the generic UI component, not the React module! labels Aug 14, 2018
@oliviertassinari oliviertassinari merged commit aa17d11 into mui:master Aug 14, 2018
@oliviertassinari
Copy link
Member

@jorgegorka I have changed the logic a bit. Let us know how using Preact with Material-UI goes!

@jorgegorka
Copy link
Contributor Author

@oliviertassinari Sure, I'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: avatar This is the name of the generic UI component, not the React module! new feature New feature or request preact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants