[lab] Depend on @babel/runtime #12470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babel/runtime will also be installed by the peerDependency on @material-ui/core, but it might also be installed by some other module or by the consuming app. That means the @babel/runtime that will actually be resolved by @material-ui/lab is not guaranteed to be the same as the one resolved by core, without an explicit dependency. In particular, I was installing @babel/runtime@7.0.0-rc.1 in my app, which has different file paths from beta.42, causing imports of @babel/runtime from @material-ui/lab to fail. This patch ensures a compatible version of the runtime is always used.
oliviertassinari
approved these changes
Aug 10, 2018
|
@goto-bus-stop well spotted! |
oliviertassinari
changed the title
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lab was missing a direct dependency on @babel/runtime.
It will be installed by the peerDependency on @material-ui/core, but it might also
be installed by some other module or by the consuming app. That means the
@babel/runtime that will actually be resolved lab is not guaranteed to be
the same as the one resolved by core, without an explicit dependency.
In particular, I was installing @babel/runtime@7.0.0-rc.1 in my app, which has different file paths
from beta.42, causing imports of @babel/runtime from @material-ui/lab to fail.
This patch ensures a compatible version of the runtime is always used.