[docs] Font vs SVG. Which approach to use? #12466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
requested changes
Aug 10, 2018
docs/src/pages/style/icons/icons.md
Outdated
|
|
||
| ## Which approach to use? | ||
|
|
||
| Both approaches work fine, however, there are some subtle differences. Especially in terms of performance and rendering quality. |
There was a problem hiding this comment.
I would use a comma after "differences", otherwise it looks good to me.
oliviertassinari
changed the title
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Aug 11, 2018
* Update icons.md * all good for me
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Aug 11, 2018
* Update icons.md * all good for me
|
Oh dear, it says "why GiHub migrated"... |
|
@jeffvandyke Do you want to submit a pull request to fix this typo 👌 ? |
|
@jeffvandyke and @oliviertassinari just created another PR to fix the typo. Apologizes for the annoyances. |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some reasoning on which approach to use. Feel free to criticize or add any comment 😉