[core] Fix some errors when porting demos to TypeScript #12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porting https://github.com/mui-org/material-ui/blob/master/docs/src/pages/demos/autocomplete/IntegrationDownshift.js to typescript does not works in line 281: ``` <Popper open={isOpen} anchorEl={popperNode}> <Paper square style={{ width: popperNode ? popperNode.clientWidth : null }}> ```
Porting https://github.com/mui-org/material-ui/blob/master/docs/src/pages/demos/dialogs/ConfirmationDialog.js to typescript does not works in line 83: ``` <RadioGroup ref={ref => { this.radioGroupRef = ref; }}```
Porting https://github.com/mui-org/material-ui/blob/master/docs/src/pages/demos/text-fields/TextFields.js to typescript does not works in line 106: ``` <TextField id="read-only-input" label="Read Only" defaultValue="Hello World" className={classes.textField} margin="normal" InputProps={{ readOnly: true, }} /> ```
| @@ -7,6 +7,7 @@ export interface RadioGroupProps | |||
| name?: string; | |||
| onChange?: (event: React.ChangeEvent<{}>, value: string) => void; | |||
| value?: string; | |||
| ref?; | |||
There was a problem hiding this comment.
Something is wrong, ref is a native React property. We shouldn't have to declare it.
| @@ -23,6 +23,7 @@ export interface InputProps | |||
| multiline?: boolean; | |||
| name?: string; | |||
| placeholder?: string; | |||
| readOnly?:boolean; | |||
There was a problem hiding this comment.
You can run yarn prettier to fix the code style.
| @@ -20,12 +20,12 @@ export type PopperPlacementType = | |||
| export interface PopperProps extends React.HTMLAttributes<HTMLDivElement> { | |||
| transition?: boolean; | |||
| anchorEl?: null | HTMLElement | ReferenceObject | ((element: HTMLElement) => HTMLElement); | |||
| children: ( | |||
| children: React.ReactElement<any> | (( | |||
There was a problem hiding this comment.
It can be a node, I believe we should be using React.ReactNode.
| props: { | ||
| placement: PopperPlacementType; | ||
| TransitionProps?: TransitionProps; | ||
| }, | ||
| ) => React.ReactElement<any>; | ||
| ) => React.ReactElement<any>); |
There was a problem hiding this comment.
React.ReactNode most likely.
oliviertassinari
added
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
oliviertassinari
changed the title
|
@PavelPZ Thank you |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting https://github.com/mui-org/material-ui/tree/master/docs/src/pages/demos to typescript arrise some errors, see my commit's comments.
Thanks for merging