Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Tomahawk boilerplate to the related projects #12393

Merged
merged 3 commits into from
Aug 3, 2018

Conversation

goemen
Copy link
Contributor

@goemen goemen commented Aug 2, 2018

No description provided.

@mbrookes
Copy link
Member

mbrookes commented Aug 3, 2018

@goemen Thanks for the PR - I think this may be better suited to "related projects" (if you plan to keep the dependencies updated).

I might borrow your login screen for an upcoming PR though, and your dashboard bears a striking resemblance to mine, even down to the choice of drawer variant! 😄

@goemen
Copy link
Contributor Author

goemen commented Aug 3, 2018

@mbrookes which one is yours? react-admin?

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 3, 2018

@mbrookes Looking at what we have in the showcase for the login, https://marmelab.com/react-admin-demo/#/login is one of my favorite.

@goemen
Copy link
Contributor Author

goemen commented Aug 3, 2018

I plan on making some improvements. @mbrookes is right, there is some resemblance there. I guess great mind think alike but I can tweak it a little bit for uniqueness

@mbrookes
Copy link
Member

mbrookes commented Aug 3, 2018

@goemen

which one is yours? react-admin?

No, just a very basic layout, not published yet.

I can tweak it a little bit for uniqueness

No need, it was just an observation. I hadn't even looked at react-admin!

@goemen
Copy link
Contributor Author

goemen commented Aug 3, 2018

@mbrookes will move the settings to the 'related projects'

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 3, 2018
@oliviertassinari oliviertassinari changed the title Adding Tomahawk boilerplate starter app [docs] Add Tomahawk boilerplate to the related projects Aug 3, 2018
@oliviertassinari oliviertassinari merged commit 81c8d84 into mui:master Aug 3, 2018
@oliviertassinari
Copy link
Member

@goemen I went ahead. Thanks for sharing your project.

@goemen
Copy link
Contributor Author

goemen commented Aug 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants