[FormControlLabel] Add labelPlacement prop #12303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +79,7 @@ function FormControlLabel(props, context) { | |||
| className={classNames( | |||
| classes.root, | |||
| { | |||
| [classes.start]: labelPlacement === 'start', | |||
There was a problem hiding this comment.
What're the pros/cons of using CSS over changing the DOM structure?
There was a problem hiding this comment.
Pros: It's simpler (so simple that it barely warrants its own prop).
Cons: ? (I'm not aware of any)
There was a problem hiding this comment.
Cons: confusing output when debugging in the dev tool. But I'm fine with the current tradeoff.
oliviertassinari
approved these changes
Jul 27, 2018
| @@ -22,6 +22,10 @@ export const styles = theme => ({ | |||
| cursor: 'default', | |||
| }, | |||
| }, | |||
| /* Styles applied to the root element if `position="start"`. */ | |||
| start: { | |||
There was a problem hiding this comment.
What do you think of?
The variants applied by and enum property are prefixed, e.g. the colorPrimary class applied by the color="primary" property.
There was a problem hiding this comment.
What do you think of renaming the start style rule, labelPositionStart?
| @@ -22,6 +22,10 @@ export const styles = theme => ({ | |||
| cursor: 'default', | |||
| }, | |||
| }, | |||
| /* Styles applied to the root element if `position="start"`. */ | |||
There was a problem hiding this comment.
labelPositition="start"
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11618
I reused the RadioButtonsGroup demo to show the label on the left, and moved the FromControl
requiredanderrorprops examples to the CheckboxesGroup example. (They never really made sense on RadioButtons.)