[Popper] Typing and documentation #12223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: Popper
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
popper_documentation
branch
2 times, most recently
from
8df326a
to
7a2ea32
Compare
|
@dispix Awesome work! The only important point I have changed is around the scroll handling. I have updated the logic for repositioning. |
oliviertassinari
force-pushed
the
popper_documentation
branch
from
7a2ea32
to
2a74fcd
Compare
|
Thanks for all the feedbacks and the quick merge ! Hope I'll be able to help again in the future :) |
|
Anytime you want :) |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR following the
Popperdiscussion in #12211.Things to clarify as I am not sure how to handle these :
ReferenceObjecttype from thepopper.jslibrary (packages/material-ui/src/Popper/Popper.d.ts@22)docs/src/pages/utils/popper/popper.md@16).Closes #12211