Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Add "space-evenly" value for justify prop #12213

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

iain-b
Copy link
Contributor

@iain-b iain-b commented Jul 20, 2018

The Grid component's justify prop doesn't accept the value "space-evenly" which is a valid value for justify-content.

(This is my first PR here and I have read the contributing docs, let me know if I've forgotten anything)

@iain-b iain-b force-pushed the grid-justify-space-evenly branch from 8c06850 to d660a31 Compare July 20, 2018 16:58
@iain-b iain-b force-pushed the grid-justify-space-evenly branch from d660a31 to cae138d Compare July 20, 2018 17:04
@oliviertassinari oliviertassinari self-assigned this Jul 20, 2018
@oliviertassinari oliviertassinari changed the title Allow "space-evenly" value for justify prop of Grid component [Grid] Add "space-evenly" value for justify prop Jul 20, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: Grid The React component. labels Jul 20, 2018
@oliviertassinari oliviertassinari removed their assignment Jul 20, 2018
@oliviertassinari oliviertassinari merged commit 7433ec2 into mui:master Jul 20, 2018
@oliviertassinari
Copy link
Member

@iain-b I haven't updated the interactive demo either. I'm not sure we need a demo for this value. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants