Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Conditional tests #12191

Merged
merged 1 commit into from
Jul 18, 2018
Merged

[test] Conditional tests #12191

merged 1 commit into from
Jul 18, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 18, 2018 •
edited
Loading

  • Add test coverage for the side packages. It's a tradeoff between test duration and coverage.
  • Remove the visual regression test for all the icons as it's significantly slow. In the future, we could add a visual regression test just for material-ui-icons and lazy running it.

@oliviertassinari oliviertassinari force-pushed the test-icons-lazy branch 3 times, most recently from 43889ad to 814d7ea Compare July 18, 2018 21:44
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 18, 2018 •
edited
Loading

@mbrookes I couldn't add material-ui-lab, the tests are broken as I'm writting these lines.

@oliviertassinari oliviertassinari merged commit 77c48ca into mui:master Jul 18, 2018
@oliviertassinari oliviertassinari deleted the test-icons-lazy branch July 18, 2018 21:56
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliviertassinari