Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve the prop-types of shape #12098

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 9, 2018

Fix the issue raised by @tzfrs in #12083 (comment)

The core idea of this change is to update the prop-types to match reality. Here is an example of issue it will solve in people code:

               <Menu
                 id="demo-menu-more"
                 anchorEl={anchorEl}
                 open={Boolean(anchorEl)}
                 onClose={this.handleCloseMore}
                 getContentAnchorEl={null}
                 anchorOrigin={{
+                  vertical: 'top',
                   horizontal: 'right',
                 }}
                 transformOrigin={{
+                  vertical: 'top',
                   horizontal: 'right',
                 }}
               >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant