Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage *without* encryption #71

Open
espressoelf opened this issue Sep 4, 2021 · 5 comments
Open

Usage *without* encryption #71

espressoelf opened this issue Sep 4, 2021 · 5 comments

Comments

@espressoelf
Copy link

From what I saw, saving notes unencrypted isn't possible with the current code and there's no "switch" to configure it to behave that way. A way to configure, i.e. turn encryption on/off, would be nice.

I know this sounds like a step back, but I personally think the risk of forgetting a password is far worse than the risk of the local admin being able to read the notes in cleartext. With the current setup, you need to fully trust the administrator (and environment the app is running) anyway.

(I think being able to use something like Mailvelope or WebPG together with mininote, or encrypting the database as whole (i.e. to be able to store it in more unsafe locations securely) would make more sense.)

@espressoelf
Copy link
Author

I've installed the Mailvelope add-on and created a new notebook (pw:1234 with 1234 as passwort) in the demo as an example and a note called secret.txt which should be safely encrypted, even though everyone can open it.

@muety
Copy link
Owner

muety commented Sep 4, 2021

Hi @espressoelf! I see the issue that not everyone might want encryption. However, I'd still like to have it included as a built-in feature. Using third-party browser plug-ins is too much of a hassle for the average user. I could imagine a solution where encryption can optionally be turned off by the server admin using a feature flag in the config. PRs are welcome!

@espressoelf
Copy link
Author

That's understandable, users want a simple solution and not another bloated complete solution for every problem. I still think the current solution is more or less a placebo, protecting a leaked db at most. I'll try to read more into the code and see if I can add something. I'll create a PR when I'm able to. Until then, I'll leave this as suggestion and also as hint for users looking for other ways to encrypt their text without trusting the server.

Feel free to close this for now if you want :)

@muety muety closed this as completed Oct 3, 2021
@muety
Copy link
Owner

muety commented Mar 3, 2022

Actually, considering the issue described in #73, I think the option to disable encryption (globally for the whole instance) would be helpful after all. I'll have a look once I get to it.

@muety
Copy link
Owner

muety commented Mar 3, 2022

I still think the current solution is more or less a placebo, protecting a leaked db at most.

Quick comment on that. The current type of encryption is more than just encryption at rest. It's in fact end-to-end encryption, but, admittedly, with the caveats mentioned at https://github.com/muety/mininote#-encryption.

We might actually get rid of the password entirely, which would drastically improve security in a way that there wouldn't be a need to trust the server admin to not use modified code anymore. I created #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants