Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong SOABI value #119

Closed
MehdiChinoune opened this issue Dec 8, 2022 · 3 comments · May be fixed by #120
Closed

Wrong SOABI value #119

MehdiChinoune opened this issue Dec 8, 2022 · 3 comments · May be fixed by #120

Comments

@MehdiChinoune
Copy link

We have encountered recently an issue when building VTK, where we have discovered that that mingw-python gives a wrong value for SOABI
on Ubunut 22.04:

>>> import sysconfig; print(sysconfig.get_config_var('EXT_SUFFIX'))
.cpython-310-x86_64-linux-gnu.so
>>> import sysconfig; print(sysconfig.get_config_var('SOABI'))
cpython-310-x86_64-linux-gnu
>>> import sysconfig; print(sysconfig.get_config_var('SO'))
<stdin>:1: DeprecationWarning: SO is deprecated, use EXT_SUFFIX
.cpython-310-x86_64-linux-gnu.so

on mingw-python/CLANG64

>>> import sysconfig; print(sysconfig.get_config_var('EXT_SUFFIX'))
.cp310-mingw_x86_64_clang.pyd
>>> import sysconfig; print(sysconfig.get_config_var('SOABI'))
cpython-310
>>> import sysconfig; print(sysconfig.get_config_var('SO'))
<stdin>:1: DeprecationWarning: SO is deprecated, use EXT_SUFFIX
.cp310-mingw_x86_64_clang.pyd

SOABI should returns cp310-mingw_x86_64_clang
@naveen521kk
Copy link
Member

We have encountered recently an issue when building VTK, where we have discovered that that mingw-python gives a wrong value for SOABI

On MSVC Python, SOABI isn't there in sysconfig.get_config_var, so I would say we should remove that rather than return the wrong value. We try to match with MSVC Python as much as possible. Is there any specific use case where you would use that value?

@MehdiChinoune
Copy link
Author

We have encountered recently an issue when building VTK, where we have discovered that that mingw-python gives a wrong value for SOABI

On MSVC Python, SOABI isn't there in sysconfig.get_config_var, so I would say we should remove that rather than return the wrong value. We try to match with MSVC Python as much as possible. Is there any specific use case where you would use that value?

CMake looks for SOABI if it is not found It looks for EXT_SUFFIX, so I have no use for it.

@naveen521kk
Copy link
Member

Changing my mind, changing could really break quite some things, there are a lot of other things not matching MSVC python there. Fixing SOABI seems simple, will have a look.

naveen521kk added a commit to naveen521kk/cpython that referenced this issue Dec 8, 2022
@naveen521kk
Make SOABI match EXT_SUFFIX
f09d174 
Fixes msys2-contrib#119
@naveen521kk naveen521kk mentioned this issue Dec 8, 2022
Draft
@lazka lazka mentioned this issue Dec 8, 2022
Merged
@naveen521kk naveen521kk mentioned this issue Feb 19, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SOABI naveen521kk/cpython
2 participants
@naveen521kk @MehdiChinoune