Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when no response.url and request is undefined #2164

Closed
averageokguy opened this issue May 23, 2024 · 1 comment
Closed

Issue when no response.url and request is undefined #2164

averageokguy opened this issue May 23, 2024 · 1 comment

Comments

@averageokguy
Copy link

as stated in the title, i'm running into an issue where we're entering this if block because !response.url === true. however, request is undefined. this results in error cascading back up the chain. i'm not fully aware of the entire repo architecture at the moment, so i can't raise PR. should this be surrounded with try/catch? check in if condition that request !== undefined? use nullish coalescing operator request?.url ?? ""?

thanks in advance!

@kettanaito
Copy link
Member

I know this came first, but I will close it in favor of #2193.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants