Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can send blank internal orders #6459

Open
Chris-Petty opened this issue Feb 10, 2025 · 0 comments
Open

Can send blank internal orders #6459

Chris-Petty opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
needs daily triage New bug to be triaged by the release team needs triage Team Ruru 🦉 Roxy, Ferg, Noel

Comments

@Chris-Petty
Copy link
Contributor

Chris-Petty commented Feb 10, 2025

What went wrong? 😲

I sent an internal order with no lines D:

Expected behaviour 🤔

You should not be able to send blank internal orders in a regular setup - N.B. There may be a valid exception for program orders that have indicator data attached! I am not sure on this front. That said you can make a blank requisition with indicator data too atm, all the lines with 0 stock from the master list get pruned.

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Make internal order
  2. Add a line
  3. Mark as "sent"
  4. The line gets pruned because it has 0 requested
  5. So an empty requisition is sent

Note I do NOT have the pref set to allow 0 requested quantities on lines, besides my interpretation is that this pref should prevent the pruning of these lines.

Image

Your environment 🌱

  • Open mSupply Version: 2.5.1 Android
@Chris-Petty Chris-Petty added needs daily triage New bug to be triaged by the release team needs triage labels Feb 10, 2025
@Chris-Petty Chris-Petty changed the title Can send blank requisitions Can send blank internal orders Feb 10, 2025
@Chris-Petty Chris-Petty added the Team Ruru 🦉 Roxy, Ferg, Noel label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs daily triage New bug to be triaged by the release team needs triage Team Ruru 🦉 Roxy, Ferg, Noel
Projects
None yet
Development

No branches or pull requests

2 participants