Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] ROS Launch Debugger & substituteVariables Support #129

Closed
seanyen opened this issue Sep 18, 2019 · 1 comment · Fixed by #304
Closed

[feature] ROS Launch Debugger & substituteVariables Support #129

seanyen opened this issue Sep 18, 2019 · 1 comment · Fixed by #304
Labels
feature request Suggested features

Comments

@seanyen
Copy link

seanyen commented Sep 18, 2019

In vscode, there is a AbstractVariableResolverService to help dynamically generate launch\attach request at runtime by using abstract variables. For example, ${file} is replaced by the active open file path. This ability enables that developers can define a generic ROS launch task and simply go to the editor to open roslaunch file and press F5 to debug.

BTW, currently we hooked our logic on the resolveDebugConfiguration and the code path didn't get a chance to run AbstractVariableResolverService for the variables resolving.

https://github.com/microsoft/vscode/blob/4c45266943228286126e1ad9f840851a0cde594d/src/vs/workbench/contrib/debug/browser/debugService.ts#L369

@seanyen seanyen added the feature request Suggested features label Sep 18, 2019
@kejxu
Copy link

kejxu commented Sep 18, 2019

good point! VS Code variables get resolved when they are passed to the debug adapter, not sure how to resolve those inside an extension's context.

some relevant ticket to vscode repo: microsoft/vscode#79518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggested features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants