Skip to content
This repository has been archived by the owner on Jan 30, 2019. It is now read-only.

Why do we have two SSD1306 samples? #284

Open
stefangordon opened this issue Jun 5, 2016 · 9 comments
Open

Why do we have two SSD1306 samples? #284

stefangordon opened this issue Jun 5, 2016 · 9 comments
Assignees

Comments

@stefangordon
Copy link

I'm confused why we have this separate sample for the SSD1306 display via SPI accepted? #113

I think this pull request was accepted in error - not only is it confusing to users because we already have the "SPIDisplay" sample (which is already an SSD1306 SPI driver), but the folder structure of the accepted PR is completely out of whack with the rest of the repository.

@EdiWang
Copy link

EdiWang commented Jun 6, 2016

I agree. I am also looking for the I2C version instead of SPI version of SSD1306, but I can not find it anywhere, seems nobody has written code for this on Windows 10.

@stefangordon
Copy link
Author

stefangordon commented Jun 6, 2016

Yes I actually ported it to an i2c version, which is why I was investigating current state. I'll get it put up somewhere later today and update here with a link if you need it @EdiWang - will figure out how to get it merged in properly later.

@stefangordon
Copy link
Author

@EdiWang I pushed my i2c sample here
https://github.com/stefangordon/IoTCore-SSD1306-Driver/tree/master/ssd1306/Display

It is basically the SPI sample but ported to I2C. I've enhanced it with the ability to define images (of arbitrary size) in addition to fonts, and added a bit of inline documentation to display.cs.

I also created a little web app you can use to design images for the screen
http://dotmatrixtool.com/

I'll get this all cleaned up and figure out how to merge in later, but feel free to use it for now.

@EdiWang
Copy link

EdiWang commented Jun 6, 2016

WOW! Thanks very much @stefangordon

That's exactly what I am looking for!

@sely2k
Copy link

sely2k commented Jun 7, 2016

hi @stefangordon the two version is because the "original version" of the sample is not well fit for the oled display 1306 with 64 line

@stefangordon
Copy link
Author

May be best to improve the original sample as it is confusing this way. If you are able feel free to assign this issue to me and I'll try to work on it in a few weeks.

@IoTGirl
Copy link
Contributor

IoTGirl commented Jun 8, 2016

You are "Assigned". Thanks Stefan!

@stefangordon
Copy link
Author

My fork is still there for people who want an i2c version, but I have not had a chance to integrate into the repo yet. Given it isn't actually a bug we can probably close the issue if appropriate.

@sukeshak
Copy link

sukeshak commented Dec 9, 2016

Thank you @stefangordon

I found this implementation very interesting since it uses System.Drawing namespace... do you guys think this method has any downside to it?
https://github.com/jakkaj/xIOT/tree/master/Samples/OLED_SSD1306

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants