Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adding an optional 'date' & 'hours' field to the 'zeit export' command. #32

Open
MaximilianSoerenPollak opened this issue Jul 24, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@MaximilianSoerenPollak
Copy link

Hey, just something I've been implementing in my personal varation of this as I find it quite usefull is to have two additional fields in the 'export' JSON that comes out of zeit export .

  • Date (showing 'DD-MM-YYYY')
  • Hours (Hours, with decimal precision, that this task has been tracked)

Now I think since maybe not everyone wants these it would be best to make them 'optional' so that you have to enable them.

Some questions for that, that I would have then would be.

  • What should the 'shortcuts' for the flags be? (-h and -d) ?

Let me know if this is something that might be interesting, and I can make a PR for it in time.
And also, any additional requierements or things it should do.

Best

@mrusme mrusme added the enhancement New feature or request label Jul 24, 2024
@mrusme
Copy link
Owner

mrusme commented Jul 24, 2024

Sounds good to me! In order to not break people's scripts, making the output optional is a good idea.

-h and -d won't conflict with anything else, however, I try to limit short flags for things that are available across multiple commands, like -p and -t. Since I don't see any other command that you might want to use these flags in, I would prefer them to be long flags (--date, --hours-decimal?) without a short variant.

What do you think?

@MaximilianSoerenPollak
Copy link
Author

Sure, I don´t mind them being long flags instead.

I have it implemented so that I just extend the Entry struct, do you think that's the best approach?

If so I will get to it right away :)

@MaximilianSoerenPollak
Copy link
Author

One question that I do have.

Should I also adapt the 'tyme' export? I'm not sure how that app/program functions and I don´t know if it can handle extra fields etc.

Let me know :)

@mrusme
Copy link
Owner

mrusme commented Jul 24, 2024

Nope, I don't think the tyme export needs adaptation. They have a fixed format that they can export/import, and that's what's implemented rn. I don't use tyme anymore, but I didn't remove the implementation in case anyone still is.

Let me get back to the other things in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants