Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

Fix deb stretch #2

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Fix deb stretch #2

merged 2 commits into from
Jul 10, 2018

Conversation

clalancette
Copy link
Contributor

There are 2 commits in here:

  1. The first one makes it so things should compile properly on Debian Stretch, by force adding a Qt5Widgets dependency.
  2. The second one cleans up some build warnings while I was in here.

libpcl-dev really has a dependency on Qt5Widgets, but that
is not expressed by the Debian Stretch packages.  We workaround
it here by forcing the dependency in both the package.xml and
the CMakeLists.txt

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
The width and height of the OccupancyGrid metadata are both
uint32, so make the loop iterator type match.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@jlblancoc
Copy link
Member

Brilliant, thanks!!

However, that build error is, I'm afraid, different than this one (which is on my radar, pending to be fixed someday... (sigh) ):

02:23:32 /usr/bin/cc  -g -O2 -fdebug-prefix-map=/tmp/binarydeb/ros-melodic-mrpt-bridge-0.1.22=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2     CMakeFiles/cmTC_01feb.dir/CheckSymbolExists.c.o  -o cmTC_01feb -rdynamic 
02:23:32 CMakeFiles/cmTC_01feb.dir/CheckSymbolExists.c.o: In function `main':
02:23:32 ./obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8: undefined reference to `pthread_create'
02:23:32 ./obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8: undefined reference to `pthread_create'
02:23:32 collect2: error: ld returned 1 exit status

That's an error in the build farm that only happens for Debian, for some reason...

I'm just curious if you succeeded in building the package on Debian without the pthread problem?

Cheers,

@jlblancoc jlblancoc merged commit 1688622 into mrpt-ros-pkg:master Jul 10, 2018
@clalancette
Copy link
Contributor Author

I'm just curious if you succeeded in building the package on Debian without the pthread problem?

I did succeed in building the package. The problem that you see with pthread_create is actually a red herring; the real error is further up in the output. In the link you shared, if you look around 2:23:30, you'll see the real reason for the failure, which this change should fix. I guess we'll find out for sure once we do a new release into Melodic :). Thanks for merging!

@clalancette clalancette deleted the fix-deb-stretch branch July 11, 2018 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants