Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi module project fix and LGPL detection fix #16

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

subes
Copy link

@subes subes commented Mar 15, 2016


This change is Reviewable

- support for multi module projects and better parent pom detection; fixes mrice#3
@mrice
Copy link
Owner

mrice commented Mar 28, 2016

@subes

THANKS SO MUCH FOR THE PULL REQUEST!!! Especially if the LGPL is getting flagged as GPL in some instances -- definitely don't want that.

My only hesitation with your PR is that I think your IDE reformatted a lot of the code (maybe just indents) and so I can't lock in on the exact change you made...

Any way you can submit a small commit or even just comment here on the change you made (I assume it was just the regex file)??? I'm happy to do the grunt work on it since it should be easy...

Again, I'm so sorry it took me 12 days to get back to you. Time is always an issue for me, but I really do respect the time you put into the PR even though it doesn't seem like it when it takes so long to respond. Thanks!

@subes
Copy link
Author

subes commented Sep 19, 2018

I modified the java file whitespaces so that the changes are more easily visible.

Github seems to be too stupid to diff the text file, so here is a screenshot that shows what has actually changed. The change is simple by just moving the lgpl checks before gpl checks, because the gpl regex would watch lgpl too...

textdiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child and Parent POM traversal
2 participants