Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failOnError property #17

Open
BBE78 opened this issue Mar 16, 2016 · 2 comments
Open

Add failOnError property #17

BBE78 opened this issue Mar 16, 2016 · 2 comments

Comments

@BBE78
Copy link

BBE78 commented Mar 16, 2016

It could be useful to avoid a build break when using the plugin. I propose to add a failOnError boolean property (set to true by default for backward compatibility).

@mrice
Copy link
Owner

mrice commented Mar 28, 2016

Hey @BBE78 --

So sorry for the delay on this one... hmmmm... I understand your point, but my thinking with breaking the build is that it should commit this kind of violence (breaking it) on your build to make engineers pay attention to the issue. Personally, I feel like nobody worries about charging up the tech debt credit card with a bunch of warnings.

But you do have a point, and the way you address it seems like a good one (making it default)

@mrice
Copy link
Owner

mrice commented Mar 28, 2016

@BBE78 my only issue right at the moment is time... think you can take a stab at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants