Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Update for depth texture sampling restrictions #29852

Closed
greggman opened this issue Nov 10, 2024 · 3 comments · Fixed by #29910
Closed

WebGPURenderer: Update for depth texture sampling restrictions #29852

greggman opened this issue Nov 10, 2024 · 3 comments · Fixed by #29910
Labels
Milestone

Comments

@greggman
Copy link
Contributor

Description

Chrome shipped with a bug where it allowed sampling depth textures with linear filting even though the spec said this is not allowed. They recently added a deprecation warning. You can see this warning by using Chrome Canary 132.0.6830.0 (Nov 10th) or newer.

Several of the WebGPU samples will trigger the deprecation warning. Eventually Chrome will remove support (probably not for several months). Firefox and Safari, when they do actually ship WebGPU, will likely follow the spec and correctly not support this.

Reproduction steps

  1. Use Chrome Canary from Nov 10th or newer
  2. Run the https://threejs.org/examples/?q=webgpu#webgpu_backdrop example
  3. Open the devtools to the JavaScript console

See ths warning:

Using a TextureType::Depth with SamplerType::Filtering is deprecated.TextureType::Depth can only be used with SamplerType::NonFiltering or SamplerType::Comparison.

Code

n/a ---------------

Live example

https://threejs.org/examples/?q=webgpu#webgpu_backdrop

Screenshots

No response

Version

r170

Device

No response

Browser

No response

OS

No response

@mrdoob
Copy link
Owner

mrdoob commented Nov 10, 2024

List of affected examples:

backdrop
backdrop/area
backdrop/water
depth texture
postprocessing/ao
postprocessing/pixel
postprocessing/ssr
refraction
shadowmap/vsm
water

@mrdoob
Copy link
Owner

mrdoob commented Nov 10, 2024

@sunag Should TSL workaround this?

@Mugen87 Mugen87 added the WebGPU label Nov 11, 2024
@sunag
Copy link
Collaborator

sunag commented Nov 11, 2024

@sunag Should TSL workaround this?

I think a TSL workaround will be useful, although most of the examples shouldn't be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants