Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialXLoader: "time" and "frame" MaterialX nodes not loaded #28985

Closed
hybridherbst opened this issue Jul 26, 2024 · 1 comment · Fixed by #29149
Closed

MaterialXLoader: "time" and "frame" MaterialX nodes not loaded #28985

hybridherbst opened this issue Jul 26, 2024 · 1 comment · Fixed by #29149
Labels
Milestone

Comments

@hybridherbst
Copy link
Contributor

Description

Seems the time and frame application nodes from MaterialX are already supported as nodes, but not processed by MaterialXLoader.

Related to #24680

Reproduction steps

  1. Load this file with MaterialXLoader: https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/resources/Materials/TestSuite/stdlib/application/time_frame.mtlx
  2. It contains two materials, one for "time" and one for "frame"
  3. Note that "time" node and "frame" node are not supported
image

Code

I tried to fix it with

	// << Application >>
	new MXElement( 'time', timerLocal, [ 'timeScale' ] ),
	// new MXElement( 'frame', ... ),

in MaterialXLoader.js, but then I get a shader error, so that doesn't seem to be the right approach. cc @sunag

Live example

Screenshots

No response

Version

r167

Device

No response

Browser

No response

OS

No response

@hybridherbst
Copy link
Contributor Author

@sunag would love your input here! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants