Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor db_Cleaning #35

Open
sangeetabhatia03 opened this issue Jun 17, 2024 · 0 comments
Open

refactor db_Cleaning #35

sangeetabhatia03 opened this issue Jun 17, 2024 · 0 comments
Assignees

Comments

@sangeetabhatia03
Copy link
Collaborator

db_cleaning on main is broken.
On rebase_sars_new, I have fixed it. However it is a bit of a tangled mess.

  • There is plenty of duplicated code
  • Things that only need to called once e.g. pathogen specific cleaning, are wrapped up in functions. These should be converted to scripts.

This task needs major refactoring otherwise it will be impossible to maintain.
I suggest each pathogen team set up pathogen specific cleaning task, and once we are all happy with the outputs, we refactor out the common bits again.
Please start from rebase_sars_new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants