Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing 'undefined' to createClient fails with >=0.12 #651

Closed
rwky opened this issue Aug 26, 2014 · 1 comment
Closed

Passing 'undefined' to createClient fails with >=0.12 #651

rwky opened this issue Aug 26, 2014 · 1 comment

Comments

@rwky
Copy link

rwky commented Aug 26, 2014

Previously I could pass undefined variables to createClient and they'd be populated as the defaults. Since 0.12 null must be passed due to the === operator.

Should the old behaviour still work? If so it's an easy fix by changing to == in createClient

@wavded
Copy link

wavded commented Aug 29, 2014

This is affecting connect-redis as well, perhaps others. Before, any undefined parameter would fill in the defaults for host and port depending on which was missing. Now it must be null and there isn't a way to just include the host (second arg) parameter (throws an error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants