Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InstructionI matching for Execution #16

Closed
mrLSD opened this issue Jan 27, 2024 · 0 comments · Fixed by #15
Closed

Fix InstructionI matching for Execution #16

mrLSD opened this issue Jan 27, 2024 · 0 comments · Fixed by #15
Assignees
@mrLSD
Labels
fix
Milestone
v0.4.1

Comments

@mrLSD
Copy link
Owner

mrLSD commented Jan 27, 2024

Description

▶️ For enum InstructionI:

'I' (Integer x32 instruction set)
type InstructionI =
    ...
    | ECALL
    | EBREAK

⚠️ for ExecuteI logic is incorrect match call:

let Execute (instr : InstructionI) (mstate : MachineState) =
    match instr with
@mrLSD mrLSD added the fix label Jan 27, 2024
@mrLSD mrLSD added this to the v0.4.1 milestone Jan 27, 2024
@mrLSD mrLSD self-assigned this Jan 27, 2024
@mrLSD mrLSD mentioned this issue Jan 27, 2024
Merged
@mrLSD mrLSD closed this as completed in #15 Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrLSD mrLSD

Labels
fix
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging a pull request may close this issue.

Feat: Fix ExecutionI and added CI mrLSD/riscv-fs
1 participant
@mrLSD