do not emit packet events and stop parsing after a parse error #15
Conversation
| } | ||
|
|
||
| Parser.prototype.parse = function (buf) { | ||
| if (this.error) { | ||
| this._resetState() | ||
| } |
There was a problem hiding this comment.
I think we should return early in the if, otherwise it keep resetting itself: if we want to parse two buffer, and the first errors, the second should be ignored. Or maybe errored, what do you think?
There was a problem hiding this comment.
I could go either way. _resetState() resets the error as well as the buffer that had the error in it so it shouldn't keep resetting.
If we don't reset the state, calling parse() again with a new buffer is guaranteed to keep emitting the same error over and over since it appends the new buffer after the old.
So we could just tell the user to throw that instance of Parser away, or reset the internal state like I'm doing here. If we do choose not to reset for them, should we at least throw an exception to make it obvious the current instance is broken?
|
Would you mind updating |
For #14.