Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IUnsubackPacket types definition #144

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ogis-yamazaki
Copy link
Contributor

The implementation sets GRANTED in response to unsuback.

this.packet.granted.push(code)

However, it is not present in the type definition of IUnsubackPacket.

export interface IUnsubackPacket extends IPacket {
cmd: 'unsuback',
reasonCode?: number,
properties?: {
reasonString?: string,
userProperties?: UserProperties
}
}

I made a PR, please check it out.

@robertsLando robertsLando merged commit beff006 into mqttjs:master Sep 27, 2023
3 checks passed
@robertsLando
Copy link
Member

@mcollina Could you do a patch release please?

@robertsLando
Copy link
Member

@mcollina Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants