stream.emit('error', err) -> stream.destroy(err) #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing |
|
@mcollina Hmm, I've fixed most of the failures by adding Any ideas? I've allowed edits by maintainers in case it's a simple thing you're able to spot. Thanks! 🙂 |
|
Unfortunately I have no time to debug this change :( |
vishnureddy17
force-pushed
the
stream-destroy
branch
from
898bb70
to
97a261b
Compare
vishnureddy17
commented
Feb 15, 2022
| @@ -180,7 +180,6 @@ function testWriteToStreamError (expected, fixture) { | |||
| const result = mqtt.writeToStream(fixture, stream) | |||
|
|
|||
| t.false(result, 'result should be false') | |||
| t.end() | |||
There was a problem hiding this comment.
Basically, this test was failing because destroy() emits error asynchronously.
Removing t.end() here is fine because the test will automatically end when two assertions are hit and will fail the test if more than 2 are hit (per the tape documentation)
|
Don't have merge permission :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #126