Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking broken for some Blu-rays in v0.30.0 #7111

Open
wwwamadeus opened this issue Nov 2, 2019 · 4 comments
Open

Seeking broken for some Blu-rays in v0.30.0 #7111

wwwamadeus opened this issue Nov 2, 2019 · 4 comments

Comments

@wwwamadeus
Copy link

wwwamadeus commented Nov 2, 2019

mpv version and platform

Commit a9d83ea (or current git master) on Linux

Reproduction steps

mpv --start=10:00 --bluray-device /path/to/bluray/disc bluray://

Expected behavior

Seeks to 10:00.

Actual behavior

The timestamp increases but the audio and video are still that of the beginning of the disc.

Log file

With a9d83ea, chapters were broken but seeking still worked:

[   0.119][v][lavf] queuing seek to 600.000000
[   0.119][v][lavf] execute seek (to 611.650667 flags 32)
[   0.119][v][lavf] seek done
[   0.119][v][cplayer] hr-seek, skipping to 600.000000

Since it has been partially reverted by 1c63869, seeking doesn't work with some discs:

[   0.082][v][demux] Stream is not seekable.
[   0.165][v][disc] queuing seek to 600.000000
[   0.165][v][cplayer] hr-seek, skipping to 600.000000
[   0.165][v][disc] execute seek (to 600.000000 flags 32)
[   0.165][v][disc] seek to: 600.000000
[   0.165][v][lavf] queuing seek to 0.000000
[   0.165][v][lavf] execute seek (to 0.000000 flags 2)
[   0.165][v][lavf] seek done
[   0.165][v][disc] seek done

Sample files

A lot of Blu-Rays are affected (not all) but I'm afraid I can't share one here. It's probably very easy to reproduce.

@ghost
Copy link

ghost commented Nov 2, 2019

https://github.com/mpv-player/mpv/wiki/FAQ#Why_is_there_no_DVDBluray_menu_support_And_DVDBD_support_in_general

Feel free to anylyze this and write a patch. If it isn't too intrusive (or, generally, located within the BD/DVD-only code), it will be accepted.

@wwwamadeus
Copy link
Author

@wm4 I was aware of mpv dropping menu support but I thought that normal playback was still supported. Especially after you reverted part of the commit dropping some features. I wouldn't report it if it had never worked but I found the culprit by bisecting the code so I thought it was worth sharing. I'm afraid I don't know enough C to fix this myself.

@CounterPillow I have updated the report to follow the template.

@ghost
Copy link

ghost commented Nov 2, 2019

Normal playback support was recently "cut down" a bit to remove its influence on the mpv core. Point is, I don't want to maintain the DVD/BD stuff anymore, and I'll raze anything that stands in the way of changes in the core to the ground.

@Dudemanguy
Copy link
Member

@wwwamadeus: If possible, could you test #15882? I wasn't able to reproduce the issue you mentioned in the OP on git master so I don't know if it will help you out or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants