-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for libplacebo (gpu-next) in the rendering API #10810
Comments
I remember it was mentioned previousily. |
Yes, |
This is an important issue for optimal support of HDR when mpv is embedded (since gpu-next greatly increases HDR usability). Embedding with |
My problem with the render API is that it's like 1000+ lines of very awkward abstractions to only give you a fraction of the features the proper VO has and probably a bunch of bugs to boot. There's a reason virtually no one has touched it. And what's the use case exactly? Embedding the mpv window so you can draw your own context menus/GUI? You can do that with I'm aware that this won't work on wayland, and it seems like macOS doesn't support it either (correct me if I'm wrong). I don't know how much "working around bad platforms" we want to deal with. Even android allows foreign window embedding. |
To the best of my knowledge, it is also what VLC does. The main playback window is embedded into a Qt application. |
Maybe off-topic, but is it possible to implement something like |
It's impossible currently. The xdg foreign protocol doesn't actually give you anything useful. There were a couple of issues about it in wayland protocols a while ago with not very positive results as usual. Edit: Also some discussion on this mpv issue. |
The IINA project also uses the render API and is hoping this issue will be addressed soon. |
Celluloid also uses it. Its the only way to embed it in a Linux app basically. Pretending Wayland isn't used by many users and the default for many makes no sense. |
As of now,
--vo=libmpv
with the OpenGL backend has features roughly equivalent to--vo=gpu
. Features only available ingpu-next
are currently not available when using the rendering API. It would be nice if we could get support for a libplacebo-based backend in the rendering API.Expected behavior of the wanted feature
An option to choose between using a
gpu
- orgpu-next
-based OpenGL backend when using--vo=libmpv
.The text was updated successfully, but these errors were encountered: