Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation JSON resource by URL #623

Closed
strarsis opened this issue Jun 29, 2018 · 4 comments
Closed

Translation JSON resource by URL #623

strarsis opened this issue Jun 29, 2018 · 4 comments

Comments

@strarsis
Copy link
Contributor

It would be great if the pannellum standalone viewer supports a parameter for passing the URL to a pannellum-translations JSON resource. Currently it doesn't seem to be possible, or at lest not documented.

@mpetroff
Copy link
Owner

mpetroff commented Jul 1, 2018

You need to use the API. I don't intend to add it to the standalone viewer.

@mpetroff mpetroff closed this as completed Jul 1, 2018
@strarsis
Copy link
Contributor Author

strarsis commented Jul 1, 2018

@mpetroff: Going even further, in my opinion, the standalone viewer, as it is meant to be standalone,
should ship with all the translations and pick the right one by UA language.

@mpetroff
Copy link
Owner

mpetroff commented Jul 1, 2018

As mentioned in #486 (comment), I have no desire to maintain a set of translations, so what you're suggesting is never going to happen.

As for the original question, I spoke too soon about having to use the API. You can include translations in a JSON configuration file passed to the standalone viewer. It won't be a separate option, though.

@strarsis
Copy link
Contributor Author

strarsis commented Jul 1, 2018

@mpetroff: Thanks. So I can indeed pass the translation strings in the tour config file.
This is an option, though ideally the content (tour) and UI (translation strings) are not mixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants