Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoding too soon #8

Closed
davedoesdev opened this issue May 16, 2017 · 1 comment
Closed

Decoding too soon #8

davedoesdev opened this issue May 16, 2017 · 1 comment
Labels
bug duplicate

Comments

@davedoesdev
Copy link
Contributor

In _read, you're decoding each chunk. However, if the chunks happen to be split in the middle of a UTF8 sequence then decoding fails.
The decoding should be done on data when it's yielded.
@davedoesdev davedoesdev mentioned this issue May 16, 2017
Closed
@mpetazzoni
Copy link
Owner

I'll close this in favor of #9, since we'll fix both at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpetazzoni @davedoesdev