You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
} else if (typeof(value) === 'object') {
markers[key] = this._prepare_markers(value);
Since the key (startIcon or endIcon) doesn't match the previous if's, and since null is an object, the code calls _prepare_markers recursively with null as the markers parameter, and then Object.entries(markers) barfs.
Should the code refrain from making the recursive call if value is null?
[On a separate note, this issue (from 4 years ago) suggests to set startIconUrl to null, but this no longer works either.]
Thank you!
The text was updated successfully, but these errors were encountered:
According to the
Configuring markers
section inREADME.md
:However, when I set it to null,
I get the following error message:
I suspect this might be due to lines 298-299 of gpx.js:
Since the key (
startIcon
orendIcon
) doesn't match the previousif
's, and sincenull
is an object, the code calls_prepare_markers
recursively withnull
as themarkers
parameter, and thenObject.entries(markers)
barfs.Should the code refrain from making the recursive call if
value
isnull
?[On a separate note, this issue (from 4 years ago) suggests to set
startIconUrl
tonull
, but this no longer works either.]Thank you!
The text was updated successfully, but these errors were encountered: