-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl + C does nothing when using firefox-android #1699
Comments
@SunriseFox we have a couple of questions to get a better picture of the issue (and how to reproduce it):
|
|
@SunriseFox Can I start work on this? |
CS-Aditya-Rawat This bug requires some more investigation to determine more details about the underlying issue (and based on that the kind of changes we would prefer to fix it as its first step), and so if you are looking for a good-first-bug as a initial contribution then this one may not be a good "entry point" (at least not yet). If a "good first bug" is what you are looking for, you may take a look to the ones not yet assigned to a contributor (or a PR recently open and linked to the issue) from this list: Or one from the "contrib:welcome" list (but be aware that the older issues in the "contrib:welcome" list may not be relevant anymore but not closed yet, and they may require a bit more experience than the one marked as "good first bug"): |
Hello: I've investigated this issue, and the problem arises in this
try {
// Got a debugger socket file to connect.
this.selectedRDPSocketFile = (
await adbUtils.discoverRDPUnixSocket(
selectedAdbDevice, selectedFirefoxApk, {
maxDiscoveryTime: unixSocketDiscoveryMaxTime,
retryInterval: unixSocketDiscoveryRetryInterval,
}
)
);
} finally {
if (isTTY(stdin)) {
stdin.removeListener('keypress', handleCtrlC);
}
} Removing the |
@rpl can you assign me to this? This would be my first contribution but I think it's a pretty easy fix |
@willdurand thanks will do |
Further investigating this happens in either of the following two conditions (in
|
@willdurand PR linked and ready ;) |
(I didn't forget about this PR, just have no time at the moment, sorry - I'll get back to it ASAP) |
Is this a feature request or a bug?
Bug.
What is the current behavior?
Ctrl + C does nothing.
What is the expected or desired behavior?
Should quit the program.
Version information (for bug reports)
The very likely bad codes:
src\extension-runners\firefox-android.js:537
#1569
The text was updated successfully, but these errors were encountered: