Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing or expanding the browser window width while the "Was this article helpful?" widget is expanded can cause the UI to break #2119

Closed
emilghittasv opened this issue Jan 14, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@emilghittasv
Copy link
Collaborator

emilghittasv commented Jan 14, 2025

Steps to reproduce
Steps to reproduce the behavior:

Expanding the "Was this article helpful" widget before shrinking the browser window width case:

  1. Go to any article.
  2. Click on the "Yes" or "No" button from the "Was this article helpful?" widget.
  3. Reduce the browser window width and notice how the widget reverts to it's initial state.
  4. Click on the "Yes" or No" button again.

Expanding the "Was this article helpful" widget after shrinking the browser window width case":

  1. Go to any article
  2. Reduce the browser window width and click on the "Yes" or "No" button from the "Was this article helpful?" widget.
  3. Increase the browser window width and notice how the widget reverts to it's initial state.
  4. Click on the "Yes" or "No" button again.

Expected behavior
No UI issues are encountered and the state of the widget should be preserved regardless of the decrease/increase in browser window width.

Actual behavior
The widget state is not preserved after reducing or increasing the browser window width and could lead to UI breakage.

Screencasts
Expanding the "Was this article helpful" widget before shrinking the browser window

Image

Expanding the "Was this article helpful" widget after shrinking the browser window width
Image

Desktop:

  • OS: Windows 11
  • Browser: Firefox

Additional context
This issue is reproducible in stage.

@emilghittasv emilghittasv added the bug Something isn't working label Jan 14, 2025
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Jan 14, 2025
@emilghittasv emilghittasv moved this from ❓ triage to 🗄 backlog in Mozilla Support Jan 14, 2025
@emilghittasv
Copy link
Collaborator Author

emilghittasv commented Jan 14, 2025

@akatsoulas The same UI issue is displayed after trying to vote the same article twice (once from tab A and once from tab B)

Would you like me to file a separate issue for this?

Image

I've filled a separate ticket for this behavior #2136

@escattone
Copy link
Contributor

This is happening because the HTML actually contains 2 .document-vote div's -- one in the sidebar, which is shown for large screen sizes, and the other in the <section class="sumo-page-section hide-on-large>...</section>, which is only shown when the .hide-on-large class kicks in (see https://github.com/mozilla/kitsune/blob/56bcd07af0aa8e050489474489fa5ba790201666/kitsune/sumo/static/sumo/scss/base/_utilities.scss#L50).

@akatsoulas akatsoulas self-assigned this Jan 15, 2025
@akatsoulas akatsoulas moved this from 🗄 backlog to 🚀 in progress in Mozilla Support Jan 15, 2025
@akatsoulas akatsoulas removed their assignment Jan 21, 2025
@akatsoulas akatsoulas moved this from 🚀 in progress to 🗄 backlog in Mozilla Support Jan 21, 2025
@escattone escattone self-assigned this Jan 21, 2025
@escattone escattone moved this from 🗄 backlog to 🚀 in progress in Mozilla Support Jan 21, 2025
@escattone escattone moved this from 🚀 in progress to 📚 review in Mozilla Support Jan 23, 2025
@akatsoulas akatsoulas moved this from 📚 review to 🔎 QA in Mozilla Support Jan 23, 2025
@emilghittasv
Copy link
Collaborator Author

I can confirm that this issue is verified fixed in stage.

Moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Jan 27, 2025
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants