Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N+1 queries in kb_overview_rows() function #2114

Closed
escattone opened this issue Jan 10, 2025 · 2 comments
Closed

N+1 queries in kb_overview_rows() function #2114

escattone opened this issue Jan 10, 2025 · 2 comments
Assignees

Comments

@escattone
Copy link
Contributor

The kb_overview_rows function within kitsune.dashboards.readouts contains multiple N+1 queries -- where N can be quite large -- which should be folded into the main docs query as annotations:

  • current_revision
  • ready_for_l10n
  • unapproved_revs
  • transdoc
  • transdoc.is_outdated()
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Jan 10, 2025
@escattone escattone changed the title N+1 queries in kitsune.dashboards.readouts.kb_overview_rows N+1 queries in kb_overview_rows() function Jan 10, 2025
@escattone escattone self-assigned this Jan 10, 2025
@escattone escattone moved this from ❓ triage to 🚀 in progress in Mozilla Support Jan 10, 2025
@escattone escattone moved this from 🚀 in progress to 📚 review in Mozilla Support Jan 10, 2025
@escattone escattone moved this from 📚 review to 🔎 QA in Mozilla Support Jan 13, 2025
@escattone
Copy link
Contributor Author

escattone commented Jan 13, 2025

QA Notes

@emilghittasv
Copy link
Collaborator

I can confirm that no regressions were introduced with any of the fields available inside the Knowledge Base Dashboard.

Moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Jan 15, 2025
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants