Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Language" link in footer locale selector leads to www.m.o #2100

Closed
janbrasna opened this issue Dec 13, 2024 · 2 comments · Fixed by mozilla/kitsune#6411
Closed

"Language" link in footer locale selector leads to www.m.o #2100

janbrasna opened this issue Dec 13, 2024 · 2 comments · Fixed by mozilla/kitsune#6411
Assignees
Labels
bug Something isn't working

Comments

@janbrasna
Copy link

Describe the bug

The "Language" heading above the locale dropdown is clickable, and links to https://www.mozilla.org/locales/ for overview of bedrock locales available for the homepage content, not sumo

Steps to reproduce

  1. Open any page and scroll to the black footer
  2. Click on 'Language' heading above the locale dropdown
  3. (Arrive at bedrock…)
  4. Pick any locale, and end up at mozilla.org home page instead of sumo.

Expected behavior

Stay on sumo.

Actual behavior

End up on bedrock.

Additional context

This was an addition in Protocol: mozilla/protocol#259

https://protocol.mozilla.org/components/detail/language-switcher says:

"The link mzp-c-cta-link is optional, and should be used only if a website has a page dedicated to language selection. If omitted, the form will be displayed visually instead"

So it should only be configured in case the site has its own page to link to from such heading.

@janbrasna janbrasna added the bug Something isn't working label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Dec 13, 2024
@janbrasna
Copy link
Author

There are https://support.mozilla.org/locales available, so that should be configured for the component.

@emilghittasv
Copy link
Collaborator

I can confirm that the "Language" link from the footer section redirects the user to the /locales page.

Moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Dec 13, 2024
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants