Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg should make locally cached files read-only #6480

Closed
catamorphism opened this issue May 14, 2013 · 4 comments
Closed

rustpkg should make locally cached files read-only #6480

catamorphism opened this issue May 14, 2013 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@catamorphism
Copy link
Contributor

Users could easily lose track of which source files are locally-cached copies of a dependency specified by a URL-like package ID. When rustpkg fetches source from a remote git repo, it should make the local copies read-only. (This won't change anyone from changing permissions on the file, but at least it will force them to think about what they're doing.)

As motivation for this, @metajack pointed out http://forums.thedailywtf.com/forums/t/27755.aspx
@catamorphism
Copy link
Contributor Author

nominating for milestone 3, feature-complete

@graydon
Copy link
Contributor

graydon commented May 16, 2013

accepted for feature-complete milestone

@thestinger
Copy link
Contributor

Bumping for triage, still unimplemented.

@catamorphism catamorphism mentioned this issue Sep 26, 2013
Closed
@catamorphism catamorphism mentioned this issue Oct 5, 2013
Closed
@catamorphism
Copy link
Contributor Author

#9732 will close this.

bors added a commit that referenced this issue Oct 11, 2013
@bors
auto merge of #9732 : catamorphism/rust/rustpkg-read-only, r=brson
2e1df8e 
r? @metajack rustpkg now makes source files that it checks out automatically read-only, and stores
them under build/.

Also, refactored the `PkgSrc` type to keep track of separate source and destination
workspaces, as well as to have a `build_workspace` method that returns the workspace
to put temporary files in (usually the source, sometimes the destination -- see
comments for more details).

Closes #6480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
3 participants
@graydon @catamorphism @thestinger