Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Unify pub for classes and pub for export #2300

Closed
nikomatsakis opened this issue Apr 25, 2012 · 4 comments
Closed

RFC: Unify pub for classes and pub for export #2300

nikomatsakis opened this issue Apr 25, 2012 · 4 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
0.4

Comments

@nikomatsakis
Copy link
Contributor

Right now classes have pub and priv sections but exported items are labeled individually. We should do the same thing, I think, for both. I'd prefer to see class items individually labeled public and private with private the default, just as with modules. Reasonable people may differ on this, however.
@marijnh
Copy link
Contributor

marijnh commented Apr 25, 2012

Agreed. I also prefer the look (flat, explicit) of per-item pub/priv declarations.

@graydon
Copy link
Contributor

graydon commented Apr 25, 2012

I'm ok with this, so long as whatever chatter-reduction technique we use in modules (pub *; or whatever) also works here. Symmetry is good, verbosity not as good.

@catamorphism
Copy link
Contributor

I'm in favor. Getting rid of pub/priv sections would make the parser a little simpler. (This would make #2292 obsolete if adopted.)

@graydon graydon mentioned this issue Apr 25, 2012
Closed
@ghost ghost assigned brson and catamorphism Apr 26, 2012
@nikomatsakis
Copy link
Contributor Author

Dup of #1893

bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2300 - InfRandomness:freebsd-environ-extern-i…
c17e68d 
…mpl, r=RalfJung

Extend `environ` linux extern implementation to freebsd

This fixes the `env` test on freebsd, and enables the CI test

Signed-off-by: InfRandomness <infrandomness@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
5 participants
@graydon @marijnh @brson @nikomatsakis @catamorphism