Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving widgets inside a dashboard has become less smooth in RC #958

Closed
madalincm opened this issue May 22, 2019 · 3 comments
Closed

Moving widgets inside a dashboard has become less smooth in RC #958

madalincm opened this issue May 22, 2019 · 3 comments
Assignees

Comments

@madalincm
Copy link

Steps to reproduce:

  1. Open a dashboard
  2. Click the options menu button from the top right corner
  3. Click on the edit button
  4. Try to move/scale the widgets/text boxed

Expected results:

The process is smooth, the widgets can easily be moved/scaled

Actual results:

The whole process is not smooth, when the user tries to move the widgets the move is jittery

Notes

Verified in FF66 win7x64 Issue can be reproduced in STMO-RC
Please view this screencast:
dashboardEdit

@madalincm madalincm added the bug label May 22, 2019
@emtwo
Copy link

emtwo commented May 29, 2019

My assessment here is that there is one issue I can consistently reproduce. It was that dragging a widget from high to low does not swap the widget with the one below it (it works if you drag the lower one up). This actually seems to be an issue in release too.

It looks like this specific issue is fixed upstream as of recently (May 16 - getredash@606cf12) which we did not pull in to our merge.

I tried to cherry pick the fix but it doesn't apply smoothly as it's quite a large change.

Maybe we can hold off on this fix until the next merge?

@jezdez
Copy link

jezdez commented Aug 2, 2019

@madalincm Can you check if this is still an issue for you? We've merged the grid refactor since the openening of this issue, so it may be smooth now?

@madalincm
Copy link
Author

Feels smoother also the issue Marina mentioned above is no longer reproducing. Tried on Win7x64 and MacOS 10.14.1 FF68 on dev stage and prod. Marking as verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants